feat(github): added workflows for ci and crates.io publish#28
Open
feat(github): added workflows for ci and crates.io publish#28
Conversation
gz
approved these changes
Apr 13, 2026
|
|
||
| - name: Cargo publish | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }} |
Owner
There was a problem hiding this comment.
lgtm; this line won't be necessary I'll add a openid connect entry for it
gz
reviewed
Apr 13, 2026
|
|
||
| jobs: | ||
| publish: | ||
| runs-on: ubuntu-24.04 |
Owner
There was a problem hiding this comment.
ideally we can add:
environment: release
gz
reviewed
Apr 13, 2026
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| - name: Install Nix | ||
| uses: cachix/install-nix-action@v31 |
Owner
There was a problem hiding this comment.
We should probably use @hash here instead of a version tag because they are not immutable in github and there have been so many supply chain attacks recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not an expert on github workflows or publishing to crates.io, so this might need some testing and a few iterations to get both workflows to run.
closes #26