Merged
Conversation
If it's non blocking, `fwrite()` in `groonga` may lose data without error. See also: groonga/groonga#2749
kou
added a commit
to groonga/groonga
that referenced
this pull request
Mar 16, 2026
If output (e.g. pipe) may not have enough buffer, `fwrite()` may not write all data. We need to call multiple `fwrite()`s to ensure writing all data. In my experience, non blocking output may not work well. `fwrite()` against non blocking output may not return `-1` with `EAGAIN` and reported written data may not be written. So, output should be blocking. See also: groonga/grntest#31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If it's non blocking,
fwrite()ingroongamay lose data without error.See also: groonga/groonga#2749