Skip to content

feat: track active Codex Desktop rollouts#129

Merged
graykode merged 2 commits into
graykode:mainfrom
YanxinXue:main
May 28, 2026
Merged

feat: track active Codex Desktop rollouts#129
graykode merged 2 commits into
graykode:mainfrom
YanxinXue:main

Conversation

@YanxinXue

Copy link
Copy Markdown
Contributor

Summary

This improves Codex Desktop session tracking in abtop.

Codex Desktop uses a long-lived codex app-server process, and that process may keep rollout JSONL files open after a thread is no longer active. Previously, file-descriptor presence alone could make stale Desktop rollouts appear as active sessions.

This PR handles Codex Desktop separately from regular Codex CLI sessions:

  • Detects codex app-server processes separately from normal Codex CLI processes.
  • Shows only fresh rollout JSONL files whose metadata identifies them as Codex Desktop.
  • Avoids attributing app-server memory, child processes, and ports to individual Desktop rollout sessions.
  • Prevents the kill action from targeting the shared Codex Desktop app-server process.
  • Extends the MCP active-rollout freshness threshold to 30 minutes.
  • Keeps Codex quota data focused on account-level rate limits instead of model-specific limits.
  • Adds tests for Desktop rollout discovery, stale rollout filtering, kill safety, and rate-limit parsing.

Why

This keeps abtop's session list focused on currently active Codex Desktop threads while avoiding stale entries from old rollouts that the Desktop app-server still has open.

It also keeps destructive session actions conservative: a shared Desktop app-server should not be treated the same way as an individual CLI session process.

Testing

  • cargo test
    • 152 passed

@graykode graykode left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm — security looks clean: no new network/dependency/workflow surface, and the kill path gets stricter for the shared Codex Desktop app-server. I reviewed the Desktop rollout filtering, rate-limit gating, and process ownership changes; local cargo test, cargo clippy -- -D warnings, and cargo build all pass.

@graykode graykode merged commit c58d7f1 into graykode:main May 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants