feat: track active Codex Desktop rollouts#129
Merged
Conversation
graykode
approved these changes
May 28, 2026
graykode
left a comment
Owner
There was a problem hiding this comment.
lgtm — security looks clean: no new network/dependency/workflow surface, and the kill path gets stricter for the shared Codex Desktop app-server. I reviewed the Desktop rollout filtering, rate-limit gating, and process ownership changes; local cargo test, cargo clippy -- -D warnings, and cargo build all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves Codex Desktop session tracking in abtop.
Codex Desktop uses a long-lived
codex app-serverprocess, and that process may keep rollout JSONL files open after a thread is no longer active. Previously, file-descriptor presence alone could make stale Desktop rollouts appear as active sessions.This PR handles Codex Desktop separately from regular Codex CLI sessions:
codex app-serverprocesses separately from normal Codex CLI processes.Codex Desktop.Why
This keeps abtop's session list focused on currently active Codex Desktop threads while avoiding stale entries from old rollouts that the Desktop app-server still has open.
It also keeps destructive session actions conservative: a shared Desktop app-server should not be treated the same way as an individual CLI session process.
Testing
cargo test