Support graphql-transport-ws websocket subprotocol#65
Open
SmileyChris wants to merge 4 commits intographql-python:masterfrom
Open
Support graphql-transport-ws websocket subprotocol#65SmileyChris wants to merge 4 commits intographql-python:masterfrom
SmileyChris wants to merge 4 commits intographql-python:masterfrom
Conversation
|
Any plan to merge this? |
pranavdxl
approved these changes
May 26, 2023
oliver-sanders
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Code looks good. I rebased this onto upstream/master and tested with the JS graphql-ws client (which confusingly uses the graphql-transport-ws protocol), worked a charm 👍.
oliver-sanders
added a commit
to oliver-sanders/cylc-uiserver
that referenced
this pull request
Aug 9, 2023
* The protocol for message exchange employed over a websocket connection is referred as the subprotocol. * We currently use the `graphql-ws` subprotocol for serving GraphQL subscriptions over websockets. * The JavaScript library which implements the `grahpql-ws` subprotocol is no longer maintained. * This PR adds support for the `graphql-transport-ws` subprotocol, allowing us to migrate our client away from this unsupported library. * This requires graphql-python/graphql-ws#65 and a new release of the Python graphql-ws library to work.
8 tasks
|
@SmileyChris Do you have write access to this repo? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make some small changes to also support the graphql-transport-ws implemented and defined at https://github.com/enisdenjo/graphql-ws