Register operation with connection context for gevent subscription#55
Closed
kahkeng wants to merge 1 commit intographql-python:masterfrom
Closed
Register operation with connection context for gevent subscription#55kahkeng wants to merge 1 commit intographql-python:masterfrom
kahkeng wants to merge 1 commit intographql-python:masterfrom
Conversation
Contributor
|
This should be fine now, merged as part of the large #46 pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this fix comes from this old pull request #11, I'm extracting it into its own PR since it is helpful independent of the pubsub implementation.
For verifying this bug, I loaded an app with a subscription, then reloaded the page multiple times. When an update happens, my backend logs that multiple updates were pushed out. With the proposed fix, only one update is sent out. Also, I noted that the other subscription server implementations (aiohttp/websockets_lib) have a
register_operationcall in theiron_starthandlers, but the gevent one does not.