Fix GraphiQL IDE rendering (#137)#138
Open
leonardwellthy wants to merge 1 commit intographql-python:mainfrom
Open
Fix GraphiQL IDE rendering (#137)#138leonardwellthy wants to merge 1 commit intographql-python:mainfrom
leonardwellthy wants to merge 1 commit intographql-python:mainfrom
Conversation
Contributor
leonardwellthy
commented
Feb 6, 2026
leonardwellthy
commented
- Fix Flask views using Jinja2's render_template_string which HTML-escaped JSON values, breaking the GraphiQL JS config. Both sync and async views now use to_template_string() with the framework-agnostic simple_renderer.
- Fix operationName not passed to the template due to a variable naming mismatch (operationName vs operation_name) in the sync Flask view.
- Restore the locationQuery JS function accidentally removed in 578453f, which caused a ReferenceError when editing queries in the GraphiQL IDE.
- Escape < and > as \u003c and \u003e in tojson() to prevent queries containing </script> from breaking the page by prematurely closing the script tag.
- Add CodeMirror 5 fold gutter CSS to fix broken fold markers in the GraphiQL editor.
- Fix Flask views using Jinja2's render_template_string which HTML-escaped JSON values, breaking the GraphiQL JS config. Both sync and async views now use to_template_string() with the framework-agnostic simple_renderer. - Fix operationName not passed to the template due to a variable naming mismatch (operationName vs operation_name) in the sync Flask view. - Restore the locationQuery JS function accidentally removed in 578453f, which caused a ReferenceError when editing queries in the GraphiQL IDE. - Escape < and > as \u003c and \u003e in tojson() to prevent queries containing </script> from breaking the page by prematurely closing the script tag. - Add CodeMirror 5 fold gutter CSS to fix broken fold markers in the GraphiQL editor.
leonardwellthy
force-pushed
the
fix/graphiql-rendering-issues-137
branch
from
3388fc1 to
5cb34ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.