Add comprehensive JSpecify @NullMarked annotations to remaining classes#262
Open
Add comprehensive JSpecify @NullMarked annotations to remaining classes#262
Conversation
Co-authored-by: andimarek <1706744+andimarek@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add comprehensive Jspecify annotations to java-dataloader
Add JSpecify migration plan document
Jan 28, 2026
Co-authored-by: andimarek <1706744+andimarek@users.noreply.github.com>
Copilot
AI
changed the title
Add JSpecify migration plan document
Add JSpecify migration plan with detailed effort estimates
Jan 28, 2026
Co-authored-by: andimarek <1706744+andimarek@users.noreply.github.com>
…ble to environment params Co-authored-by: andimarek <1706744+andimarek@users.noreply.github.com>
Copilot
AI
changed the title
Add JSpecify migration plan with detailed effort estimates
Add comprehensive JSpecify nullness annotations to all remaining classes
Jan 29, 2026
Copilot
AI
changed the title
Add comprehensive JSpecify nullness annotations to all remaining classes
Add comprehensive JSpecify @NullMarked annotations to remaining classes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes JSpecify nullness annotation coverage across the library. Previously ~21 files were annotated; this adds annotations to the remaining ~32 files.
Changes
Try,DataLoaderOptions,BatchLoaderContextProvider): Mark nullable throwable field, optional builder fields, nullable context returnnonNull()accepts@Nullableinput;cause()returns@NullablebeginXXX()methods return@Nullable;onCompletedparams nullableenvironmentparam marked@Nullable(null for simple loaders)callContextslist elements nullableType bound fix
NullAway suppressions
Two suppressions for known generic type inference limitations:
AbstractBatchSubscriber.onError()—List<@Nullable Object>constructorDataLoaderInstrumentationHelper.whenCompleted()—BiConsumernullabilityOther
KotlinExamples.ktexplicit type params for stricter nullabilityJSPECIFY_MIGRATION_PLAN.mdwith completion status💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.