Route simple OPTIONAL MATCH through native physical dispatch#1463
Merged
Conversation
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1460.
Simple input-free top-level
OPTIONAL MATCHnow gets a native logical plan and dispatches through the same-path physical route instead of_execute_compiled_query_compat_non_union().Scope
OPTIONAL MATCHasPatternMatch(optional=True, arm_id="top_level_optional_0").Validation
python3 -m pytest -q graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/cypher/test_lowering.py::test_compiled_query_sets_logical_plan_route_for_top_level_optional_shape graphistry/tests/compute/gfql/cypher/test_lowering.py::test_compiled_query_sets_logical_plan_defer_reason_for_optional_reentry_shape->37 passedpython3 -m pytest -q graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/test_physical_planner.py -k 'not cudf'->976 passed, 12 skipped, 111 deselected./bin/ruff.sh graphistry/compute/gfql/logical_planner.py graphistry/compute/gfql/cypher/lowering.py graphistry/tests/compute/gfql/test_logical_planner.py graphistry/tests/compute/gfql/cypher/test_lowering.py graphistry/tests/compute/gfql/test_runtime_physical_cutover.py-> green./bin/typecheck.sh-> greengit diff --check-> cleanRAPIDS_VERSION=25.02 PROFILE=gfql WITH_GPU=1 WITH_IMAGE_BUILD=0 TEST_FILES="graphistry/tests/compute/gfql graphistry/tests/compute/test_gfql.py" docker/test-rapids-official-local.sh->2368 passed, 22 skipped, 15 xfailedRAPIDS_VERSION=26.02 PROFILE=gfql WITH_GPU=1 WITH_IMAGE_BUILD=1 TEST_FILES="graphistry/tests/compute/gfql graphistry/tests/compute/test_gfql.py" docker/test-rapids-official-local.sh->2368 passed, 22 skipped, 15 xfailedLocal cuDF/GPU suites fail on this workstation with
cudaErrorNoDevice; DGX GPU validation covered both requested RAPIDS versions.