fix: Use ServiceName + MethodName as the regex for Otel#2543
Merged
diegomarquezp merged 6 commits intomainfrom Mar 3, 2026
Merged
fix: Use ServiceName + MethodName as the regex for Otel#2543diegomarquezp merged 6 commits intomainfrom
diegomarquezp merged 6 commits intomainfrom
Conversation
product-auto-label
bot
added
size: s
|
|
|
|
blakeli0
approved these changes
Mar 3, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2502
Use a consistent Regex matching pattern for both gRPC and HttpJson. Copy the pattern used for gRPC into HttpJson.
Looking at the Method Descriptor for HttpJson (Compute as an example), the full method name does not match
service.resource.action: https://github.com/googleapis/google-cloud-java/blob/1f9e63224424327a08e3663985773546b3f7808b/java-compute/google-cloud-compute/src/main/java/com/google/cloud/compute/v1/stub/HttpJsonBackendServicesStub.java#L85It seems to match
ServiceName/MethodName.