-
Notifications
You must be signed in to change notification settings - Fork 172
feat(storage): add abstracts for blob, and bucket #1750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: async
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a more robust and extensible architecture for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces abstract base classes for Blob and Bucket, which is a good step towards a more defined and extensible API. The concrete classes are updated to inherit from these new ABCs. My review focuses on ensuring the new abstract classes are consistent and correctly define the public interface. I've found a couple of minor inconsistencies in BaseBucket that should be addressed.
5bc607d to
48f3ecd
Compare
55189ff to
7dc2788
Compare
7dc2788 to
66bd239
Compare
66bd239 to
821e77a
Compare
chore: remove python 3.9 support. Details in b/483015736
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a unit test for test_blob.py that it now inherits from BaseBlob ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as this - https://github.com/googleapis/python-storage/pull/1750/changes#r2802654879
add abstracts for blob, and bucket