Remove duplicate diagnostic pragmas#171
Open
SamB wants to merge 2 commits into
Open
Conversation
Clang has been unconditionally accepting the GCC diagnostic pragmas since before the clang pragmas were introduced in [r71572][1]. This means we don't need to duplicate the pragmas for clang-cl's benefit. [1]: llvm/llvm-project@b61448d
Author
|
Note that I didn't commit release/c/wuffs-unsupported-snapshot.c because I'm allergic to commiting generated files without specific instructions to do so. |
Collaborator
|
Please commit |
Author
|
@nigeltao Ok, committed. Tangentially-related sillinessI started to rebase but thought better of it; I'm not sure why I thought commiting the C file would magically create merge conflicts when the only thing I changed is a literal that we paste at the beginning of the output, and there was no conflict in the literal itself ...Turning on my brain, that would only happen if
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang has been unconditionally accepting the GCC diagnostic pragmas since before the clang pragmas were introduced in r71572.
This means we don't need to duplicate the pragmas for clang-cl's benefit.