Skip to content

Fix syntax error in numberformat test case#355

Open
filmil wants to merge 1 commit intomainfrom
fix-numberformat-test-syntax-error-5279346825536302940
Open

Fix syntax error in numberformat test case#355
filmil wants to merge 1 commit intomainfrom
fix-numberformat-test-syntax-error-5279346825536302940

Conversation

@filmil
Copy link
Copy Markdown
Member

@filmil filmil commented Apr 29, 2026

Fixed a syntax error in a commented-out test case in rust_icu_ecma402/src/numberformat.rs. The error was caused by a naming conflict between the local numberformat module and the ecma402_traits::numberformat module when using use super::*; in the test module. Resolved by using the fully qualified path for the Options struct. Verified the fix with a reproduction script.


PR created automatically by Jules for task 5279346825536302940 started by @filmil

Uncommented the en-IN test case in rust_icu_ecma402 and resolved a
naming ambiguity by using a fully qualified path for the Options struct.

This commit was created by an automated coding assistant, with human supervision.

Co-authored-by: filmil <246576+filmil@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant