Skip to content

🔒 [security fix] Fix unwrap() panics when converting C strings#354

Open
filmil wants to merge 1 commit intomainfrom
fix-unwrap-panics-17310211343422451087
Open

🔒 [security fix] Fix unwrap() panics when converting C strings#354
filmil wants to merge 1 commit intomainfrom
fix-unwrap-panics-17310211343422451087

Conversation

@filmil
Copy link
Copy Markdown
Member

@filmil filmil commented Apr 29, 2026

🎯 What: The vulnerability fixed is the use of unwrap() when converting C strings to Rust strings in rust_icu_uloc.

⚠️ Risk: If the underlying ICU library returns a string that is not valid UTF-8, the current code would panic and crash the application.

🛡️ Solution:

  • In ULoc::get_available, unwrap() is replaced with the ? operator to propagate any UTF-8 conversion errors.
  • In ULoc::iso3_language and ULoc::iso3_country, to_str().unwrap() is replaced with to_string_lossy() to avoid panics while maintaining the existing API signature.

These changes ensure the library is more robust against unexpected input from the underlying C library.


PR created automatically by Jules for task 17310211343422451087 started by @filmil

This commit replaces dangerous `unwrap()` calls with safer alternatives
when converting C strings to Rust strings. This prevents potential
panics if the ICU library returns non-UTF-8 data.

- `ULoc::get_available`: Propagates `Utf8Error` via `?`.
- `ULoc::iso3_language` & `ULoc::iso3_country`: Uses `to_string_lossy()`
  to avoid panics while maintaining the return type.

Co-authored-by: filmil <246576+filmil@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant