Added canonical test cases for invalid packet input (#29)#167
Merged
hchataing merged 5 commits intogoogle:mainfrom Mar 3, 2026
Merged
Added canonical test cases for invalid packet input (#29)#167hchataing merged 5 commits intogoogle:mainfrom
hchataing merged 5 commits intogoogle:mainfrom
Conversation
added trailing bytes, enum validation, array size alignment checks
added trailing bytes and array size alignment checks
Collaborator
|
Thanks for the patch :) |
Collaborator
|
LGTM, thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Cases
15 invalid test vectors (LE), covering 5 error types across 6 packets:
InvalidLengthError (3 cases)
TrailingBytes (2 cases)
InvalidEnumValueError (5 cases)
InvalidFixedValue (4 cases)
InvalidArraySize (1 case)
The BE test vectors mirror these except Enum_Incomplete_Truncated_Closed (LE only), giving 12 BE cases.
Closes #29