Skip to content

Adding multi-arch support for linux/ppc64le in ml-metadata#171

Open
amitmukati-2604 wants to merge 2 commits into
google:masterfrom
amitmukati-2604:ml-metadata
Open

Adding multi-arch support for linux/ppc64le in ml-metadata#171
amitmukati-2604 wants to merge 2 commits into
google:masterfrom
amitmukati-2604:ml-metadata

Conversation

@amitmukati-2604

Copy link
Copy Markdown

No description provided.

@lehrig

lehrig commented Feb 15, 2023

Copy link
Copy Markdown

Note that this PR is part of a greater effort to enable Kubeflow and all its dependencies for multiple processor architectures (we start with ppc64le): kubeflow/community#781

@BrianSong

Copy link
Copy Markdown
Contributor

Hi @lehrig, I have transferred to another team. Please reach out to @ryanpeters-google as he is the owner for MLMD OSS now.

@lehrig

lehrig commented Mar 9, 2023

Copy link
Copy Markdown

Alright, so @ryanpeters-google, are we good to proceed here?

@ryanpeters-google

Copy link
Copy Markdown

Due to an internal issue unrelated to the content of this PR, I am unable to test your change at this time. I am working to resolve the issue internally. Targeting Q2 for resolution.

@pranavpandit1

Copy link
Copy Markdown

@ryanpeters-google: Any updates on this request?
cc @lehrig @amitmukati-2604

@XinranTang XinranTang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :) Could you provide some end-to-end results to show how you are able to build MLMD on ppc64le platforms?

unzip \
software-properties-common \
git \
openjdk-8-jdk

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openjdk-8-jdk
openjdk-8-jdk \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this dependency is needed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this dependency because bazel binary for linux/ppc64le needs java.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinranTang - does that clarify your question?

@thesuperzapper

thesuperzapper commented Dec 14, 2023

Copy link
Copy Markdown

I believe my PR #188 (for ARM64) could be extended with PPC64 support once merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants