Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

scales and helpers#37

Open
jodinathan wants to merge 3 commits into
google:masterfrom
jodinathan:master
Open

scales and helpers#37
jodinathan wants to merge 3 commits into
google:masterfrom
jodinathan:master

Conversation

@jodinathan
Copy link
Copy Markdown

Added scales property and the static helpers

Added scales property and the static helpers
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jodinathan
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Comment thread .gitignore Outdated
.pub/
pubspec.lock

\.DS_Store
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes. This should be in ~/.gitignore_global

Comment thread lib/chartjs.dart
void onHover(MouseEvent event, ChartLegendItem legendItem),
ChartLegendLabelOptions labels,
bool reverse});
bool reverse
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert white-space only changes

Comment thread lib/chartjs.dart
external factory Chart(
dynamic /*String|CanvasRenderingContext2D|CanvasElement|ArrayLike<CanvasRenderingContext2D|CanvasElement>*/ context,
ChartConfiguration options);
external get scales;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have a type?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't work if I put a type because it must be accessed like a map ['prop']. Asked on gitter and SO how to solve but didn't find a solution

Comment thread .gitignore
.packages
.pub/
pubspec.lock

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert changes here entirely

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants