scales and helpers#37
Conversation
Added scales property and the static helpers
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| .pub/ | ||
| pubspec.lock | ||
|
|
||
| \.DS_Store |
There was a problem hiding this comment.
Please revert these changes. This should be in ~/.gitignore_global
| void onHover(MouseEvent event, ChartLegendItem legendItem), | ||
| ChartLegendLabelOptions labels, | ||
| bool reverse}); | ||
| bool reverse |
There was a problem hiding this comment.
please revert white-space only changes
| external factory Chart( | ||
| dynamic /*String|CanvasRenderingContext2D|CanvasElement|ArrayLike<CanvasRenderingContext2D|CanvasElement>*/ context, | ||
| ChartConfiguration options); | ||
| external get scales; |
There was a problem hiding this comment.
it doesn't work if I put a type because it must be accessed like a map ['prop']. Asked on gitter and SO how to solve but didn't find a solution
| .packages | ||
| .pub/ | ||
| pubspec.lock | ||
|
|
There was a problem hiding this comment.
please revert changes here entirely
Added scales property and the static helpers