Validate file paths in ReadFile and sanitize HTML in process table#3864
Open
mohammadmseet-hue wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…table - manager/container.go: Verify that the resolved file path in ReadFile stays within the expected container root prefix after path.Join normalization. - containers.js: Add escapeHtml() to sanitize string values rendered in the process listing table where allowHtml is enabled, and use encodeURI for the cgroup link href.
mohammadmseet-hue
force-pushed
the
fix-filepath-validation-and-html-sanitization
branch
from
fbf6404 to
03255bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manager/container.go: After
path.Joinresolves the file path inReadFile, verify the result stays within the expected container root prefix. This prevents../sequences in the input from resolving to paths outside the intended directory.cmd/internal/pages/assets/js/containers.js: Add
escapeHtml()helper and apply it to all string fields (user,start_time,status,running_time,cmd,cgroup_path) rendered in the process listing table whereallowHtml: trueis set. The cgroup linkhrefis also wrapped withencodeURI().Test plan
go build ./...passes (verified locally)../that escape the container root🤖 Generated with Claude Code