Skip to content

fix: add v-prefixed GHCR image tags for release consistency#3857

Open
hwan515 wants to merge 1 commit intogoogle:masterfrom
hwan515:fix/add-v-prefix-ghcr-tags
Open

fix: add v-prefixed GHCR image tags for release consistency#3857
hwan515 wants to merge 1 commit intogoogle:masterfrom
hwan515:fix/add-v-prefix-ghcr-tags

Conversation

@hwan515
Copy link
Copy Markdown

@hwan515 hwan515 commented Mar 26, 2026

Summary

  • Add type=semver,pattern=v{{version}} to the container publish workflow
  • This publishes both 0.55.1 and v0.55.1 tags to GHCR
  • Fixes the inconsistency where GitHub Releases use v-prefixed tags but GHCR images don't

Problem

Users look at the Releases page and see v0.55.1, then naturally run:

docker pull ghcr.io/google/cadvisor:v0.55.1
# Error: not found

This has broken CI/CD pipelines (see #3856, #3712, #3807).

Change

One line added to .github/workflows/publish-container.yml:

type=semver,pattern=v{{version}}

This makes docker/metadata-action generate an additional tag with the v prefix, so both formats work.

Test plan

  • For tag v0.55.1, the workflow will now generate:
    • 0.55.1 (existing, {{version}})
    • v0.55.1 (new, v{{version}})
    • 0.55 (existing, {{major}}.{{minor}})
    • latest
    • SHA-based tag

Fixes #3856

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 26, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hwan515
Copy link
Copy Markdown
Author

hwan515 commented Mar 26, 2026

I have signed the Google CLA. Please re-check.

GitHub Releases use v-prefixed tags (e.g. v0.55.1), but GHCR image tags
only have the bare version (e.g. 0.55.1). This causes users to get
"not found" errors when they use the release tag directly in docker pull.

Add `type=semver,pattern=v{{version}}` so both `0.55.1` and `v0.55.1`
tags are published, matching user expectations.

Fixes google#3856
@hwan515 hwan515 force-pushed the fix/add-v-prefix-ghcr-tags branch from e99a986 to 61429aa Compare March 26, 2026 16:31
@hwan515
Copy link
Copy Markdown
Author

hwan515 commented Mar 26, 2026

/gclabot re-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GHCR image tags missing 'v' prefix, inconsistent with GitHub Releases

1 participant