fix: add v-prefixed GHCR image tags for release consistency#3857
Open
hwan515 wants to merge 1 commit intogoogle:masterfrom
Open
fix: add v-prefixed GHCR image tags for release consistency#3857hwan515 wants to merge 1 commit intogoogle:masterfrom
hwan515 wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have signed the Google CLA. Please re-check. |
GitHub Releases use v-prefixed tags (e.g. v0.55.1), but GHCR image tags
only have the bare version (e.g. 0.55.1). This causes users to get
"not found" errors when they use the release tag directly in docker pull.
Add `type=semver,pattern=v{{version}}` so both `0.55.1` and `v0.55.1`
tags are published, matching user expectations.
Fixes google#3856
e99a986 to
61429aa
Compare
Author
|
/gclabot re-check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type=semver,pattern=v{{version}}to the container publish workflow0.55.1andv0.55.1tags to GHCRv-prefixed tags but GHCR images don'tProblem
Users look at the Releases page and see
v0.55.1, then naturally run:docker pull ghcr.io/google/cadvisor:v0.55.1 # Error: not foundThis has broken CI/CD pipelines (see #3856, #3712, #3807).
Change
One line added to
.github/workflows/publish-container.yml:type=semver,pattern=v{{version}}This makes
docker/metadata-actiongenerate an additional tag with thevprefix, so both formats work.Test plan
v0.55.1, the workflow will now generate:0.55.1(existing,{{version}})v0.55.1(new,v{{version}})0.55(existing,{{major}}.{{minor}})latestFixes #3856