feat(manager/container): add configurable initial splay and max jitter factors#3854
Merged
dims merged 1 commit intogoogle:masterfrom Apr 16, 2026
Merged
Conversation
Contributor
Author
|
Hi @dims |
dims
reviewed
Apr 13, 2026
sambhav-jain-16
force-pushed
the
splay-and-jitter
branch
from
5d9cf56 to
65a4ff7
Compare
Contributor
Author
|
integration tests failing with |
Collaborator
switch to |
Contributor
Author
Created a different PR for this #3865, will rebase this PR after merging the fix |
sambhav-jain-16
force-pushed
the
splay-and-jitter
branch
from
65a4ff7 to
06fc0aa
Compare
sambhav-jain-16
force-pushed
the
splay-and-jitter
branch
from
06fc0aa to
0b6b1af
Compare
Contributor
Author
|
Hi @dims |
dims
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extension of #2918.
The initial jitter PR aims to avoid CPU spikes when hundreds of HKs are running. Although it does the job as intended, the actual interval ranges from [HK, 2HK], resulting in higher variance when
cadvisormetric timestamps are considered for rate calculations in counter metrics. Since the jitter factor is not configurable, it is impossible to reduce the variance in the current scenarios.Also, a good way to avoid CPU spikes is to spread out the container HKs initially, so that subsequent jitter can be set to zero and we get the same benefit as with random jitter every time.
To keep the change backward-compatible, the default values are set to
1.0.Attaching a screenshot showing how this change helped to reduce variance with initial splay at
1.0and jitter factor at0.0, without CPU spikes incadvisor.