-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: expose live_session_resumption_update in events for cross-connection resumption #4358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: expose live_session_resumption_update in events for cross-connection resumption #4358
Conversation
…ction resumption Fixes google#4357 When building voice assistants with Gemini Live API, applications need to persist session resumption handles for cross-WebSocket-connection resumption. Currently, ADK receives and stores these handles internally but never exposes them to applications. This change adds a handler for `live_session_resumption_update` before the skip condition in `_postprocess_live`, following the same pattern used for transcription events. This allows applications to: 1. Capture the handle when received via `event.live_session_resumption_update` 2. Persist it to session state 3. Pass it on reconnection via `SessionResumptionConfig(handle=saved_handle)` The fix enables conversation continuity when users: - Switch networks (WiFi → cellular) - Refresh browser tabs - Background mobile apps briefly - Experience brief connectivity drops
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @AshleyMaloney, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness of Gemini Live API voice assistants by exposing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a useful feature to expose live_session_resumption_update in events, enabling applications to implement cross-connection session resumption. The implementation correctly places the new logic in _postprocess_live to handle these updates. I've suggested a small refactoring to centralize all logic related to session resumption updates within _postprocess_live for better code clarity and consistency. Overall, this is a solid contribution.
…tprocess_live Address review feedback from gemini-code-assist: - Move handle storage from _receive_from_model to _postprocess_live - Use %s logging format instead of f-string for performance - Consolidate all resumption update logic in one place for consistency
Fixes #4357
Summary
Expose
live_session_resumption_updatein events so applications can implement cross-WebSocket-connection session resumption for Gemini Live API voice assistants.Problem
When building voice assistants with
run_live(), ADK receives session resumption handles from Gemini and stores them internally, but never exposes them to applications. This prevents implementing conversation continuity when users:Solution
Add a handler for
live_session_resumption_updatebefore the skip condition in_postprocess_live, following the same pattern used for transcription events.Usage
Testing
Happy to add unit tests or documentation updates if requested.