feat(gooddata-sdk): [AUTO] Add /binary endpoint for Apache Arrow execution results (BETA)#1539
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add /binary endpoint for Apache Arrow execution results (BETA)#1539yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…ution results (BETA)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1539 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 230 230
Lines 15400 15402 +2
=======================================
+ Hits 12114 12116 +2
Misses 3286 3286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
read_result_arrow()to theExecutionclass, delegating toBareExecutionResponse.read_result_arrow(). The/binaryendpoint for Apache Arrow execution results was already implemented inBareExecutionResponseusing the rawcall_apiapproach; the missing piece was exposing this method on the higher-levelExecutionclass (which already delegatedread_result()andcancel()toBareExecutionResponsebut notread_result_arrow()). Added two unit tests verifying the delegation returns apyarrow.Tableand calls the correct/binaryendpoint path.Impact: new_feature | Services:
gooddata-afm-clientTickets: CQ-104
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/tests/compute/test_bare_execution_response.pySource commits (gdc-nas)
78be9c1Merge pull request #21285 from gooddata/dho/cq-104-arrow-api81eb97aMerge pull request #21382 from gooddata/dho/cq-104-arrow-api-2OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow