feat(gooddata-sdk): [AUTO] Add DashboardArbitraryAttributeFilter and DashboardMatchAttributeFilter#1536
Open
yenkins-admin wants to merge 1 commit intomasterfrom
Open
feat(gooddata-sdk): [AUTO] Add DashboardArbitraryAttributeFilter and DashboardMatchAttributeFilter#1536yenkins-admin wants to merge 1 commit intomasterfrom
yenkins-admin wants to merge 1 commit intomasterfrom
Conversation
…DashboardMatchAttributeFilter
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
+ Coverage 78.66% 78.67% +0.01%
==========================================
Files 230 230
Lines 15400 15410 +10
==========================================
+ Hits 12114 12124 +10
Misses 3286 3286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
uses_arbitrary_values: bool | None = Noneoptional parameter toAttributeFilter.__init__()(with a corresponding property), and updatedPositiveAttributeFilter.as_api_model()andNegativeAttributeFilter.as_api_model()to conditionally pass this field to the generated API client body models. TheDashboardArbitraryAttributeFilterandDashboardMatchAttributeFilterare new schemas added to theDashboardFilteroneOf — but the SDK stores dashboard content as rawdict[str, Any](no typed wrappers exist for anyDashboardFiltervariants), so no SDK wrapper changes are needed for those types; the auto-generated API client already handles them. Unit tests were added for the newuses_arbitrary_valuesfield on both positive and negative attribute filters.Impact: new_feature | Services:
gooddata-automation-client,gooddata-export-client,gooddata-metadata-client,gooddata-afm-clientTickets: CQ-2114
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.pypackages/gooddata-sdk/tests/compute_model/test_attribute_filters.pySource commits (gdc-nas)
af3e42dMerge pull request #21504 from gooddata/dho/cq-2114-automation-filters0468f7fMerge pull request #21536 from gooddata/dho/cq-2114-propc9c966bMerge pull request #21589 from gooddata/dho/cq-2114-flagOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow