Skip to content

feat(gooddata-sdk): [AUTO] Add DashboardArbitraryAttributeFilter and DashboardMatchAttributeFilter#1536

Open
yenkins-admin wants to merge 1 commit intomasterfrom
auto/openapi-sync-C006-20260413
Open

feat(gooddata-sdk): [AUTO] Add DashboardArbitraryAttributeFilter and DashboardMatchAttributeFilter#1536
yenkins-admin wants to merge 1 commit intomasterfrom
auto/openapi-sync-C006-20260413

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Summary

Added uses_arbitrary_values: bool | None = None optional parameter to AttributeFilter.__init__() (with a corresponding property), and updated PositiveAttributeFilter.as_api_model() and NegativeAttributeFilter.as_api_model() to conditionally pass this field to the generated API client body models. The DashboardArbitraryAttributeFilter and DashboardMatchAttributeFilter are new schemas added to the DashboardFilter oneOf — but the SDK stores dashboard content as raw dict[str, Any] (no typed wrappers exist for any DashboardFilter variants), so no SDK wrapper changes are needed for those types; the auto-generated API client already handles them. Unit tests were added for the new uses_arbitrary_values field on both positive and negative attribute filters.

Impact: new_feature | Services: gooddata-automation-client, gooddata-export-client, gooddata-metadata-client, gooddata-afm-client
Tickets: CQ-2114

Files changed

  • packages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.py
  • packages/gooddata-sdk/tests/compute_model/test_attribute_filters.py

Source commits (gdc-nas)

  • af3e42d Merge pull request #21504 from gooddata/dho/cq-2114-automation-filters
  • 0468f7f Merge pull request #21536 from gooddata/dho/cq-2114-prop
  • c9c966b Merge pull request #21589 from gooddata/dho/cq-2114-flag
OpenAPI diff
+      "DashboardArbitraryAttributeFilter": {
+        "properties": { "arbitraryAttributeFilter": {
+            "properties": { "displayForm": {...}, "values": {...}, "negativeSelection": {...}, "validateElementsBy": {...} },
+            "required": ["displayForm", "negativeSelection", "values"]
+        } },
+        "required": ["arbitraryAttributeFilter"]
+      },
+      "DashboardMatchAttributeFilter": {
+        "properties": { "matchAttributeFilter": {
+            "properties": { "caseSensitive": {...}, "displayForm": {...}, "literal": {...}, "operator": { "enum": ["contains","startsWith","endsWith"] } },
+            "required": ["caseSensitive","displayForm","literal","negativeSelection","operator"]
+        } },
+        "required": ["matchAttributeFilter"]
+      },
       (DashboardFilter oneOf)
+          { "$ref": "#/components/schemas/DashboardArbitraryAttributeFilter" },
+          { "$ref": "#/components/schemas/DashboardMatchAttributeFilter" },
       (NegativeAttributeFilter / PositiveAttributeFilter)
+              "usesArbitraryValues": { "description": "If true, values were filled free-form.", "type": "boolean" }

Workflow run


Generated by SDK OpenAPI Sync workflow

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (d7f50b7) to head (7effe1e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   78.66%   78.67%   +0.01%     
==========================================
  Files         230      230              
  Lines       15400    15410      +10     
==========================================
+ Hits        12114    12124      +10     
  Misses       3286     3286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant