Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Read email addresses, phone numbers, postal addresses and instant messaging #9

Open
ened wants to merge 3 commits into
goderbauer:masterfrom
ened:additional-fields
Open

Read email addresses, phone numbers, postal addresses and instant messaging #9
ened wants to merge 3 commits into
goderbauer:masterfrom
ened:additional-fields

Conversation

@ened

@ened ened commented Jun 27, 2018

Copy link
Copy Markdown
  • the example now links to the simple_permissions plugin in order to gain access to the users address book
  • the dart class now returns a new data structure

@rodydavis

Copy link
Copy Markdown

Very nice!

@ened

ened commented Jun 27, 2018

Copy link
Copy Markdown
Author

BTW, just noticed I left a incorrect simple_permissions dependency in there. Once https://github.com/Ethras/flutter_simple_permissions/pull/19 is merged and a new plugin version is released, I will update the PR.

@rodydavis

Copy link
Copy Markdown

Sounds great. I had been using a custom contact service plugin and it was such a pain and hack to do what I was wanting with this plugin

@rodydavis

Copy link
Copy Markdown

@ened I have actually had better luck with simple_permissions instead of flutter_simple_permissions btw

@ened

ened commented Jun 28, 2018

Copy link
Copy Markdown
Author

@AppleEducate I believe those two are the same.

@rodydavis

Copy link
Copy Markdown

@ened I took what you did on your fork and merged the fields from flutter_contacts and updated the example. what do you think?
https://github.com/AppleEducate/contact_picker

@goderbauer

Copy link
Copy Markdown
Owner

Very cool! I'll probably get around to review the code on the weekend.

@ened

ened commented Jul 11, 2018

Copy link
Copy Markdown
Author

@AppleEducate not sure yet - what is the intention of removing ims, for example?
I'd be happy to work on this PR first while keeping the changes as generic as possible.

@goderbauer Do you have comments?

@rodydavis

Copy link
Copy Markdown

@ened I can try to add it back but it was throwing Everytime a IMS returned with data when I selected a contact. If it was null it didn't crash. It is a weird bug.

I'll clean up the PR

@ened

ened commented Jul 11, 2018

Copy link
Copy Markdown
Author

@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August.

@rodydavis

rodydavis commented Jul 11, 2018 via email

Copy link
Copy Markdown

@GroovinChip

Copy link
Copy Markdown

Is this pull request ever going to be merged?

@guyzk

guyzk commented Mar 10, 2019

Copy link
Copy Markdown

@ened @goderbauer
Is this plugin ever going to get updated?
This is a very needed feature by several apps i believe.
It would be most appreciated if you could merge this pull request and fix the androidX support.
Thanks!

@rodydavis

Copy link
Copy Markdown

I’ve been a using my dependency override for quite some time now

@dexcell

dexcell commented Mar 23, 2019

Copy link
Copy Markdown

I personally oppose this pull request, the beauty of this plugin is to pick your contact without any permission.

I think it's better to create different/separate plugin if you need more detail about the contact with permission.

@rodydavis

Copy link
Copy Markdown

I’ll make a separate plugin then, thank you

@guyzk

guyzk commented Mar 24, 2019

Copy link
Copy Markdown

I’ll make a separate plugin then, thank you

Waiting for an update!!!
Thanks!

@rodydavis

Copy link
Copy Markdown

@guyzk in the mean time you can use my fork of this plugin! I am already doing this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants