Skip to content

feat: add Close() to mongoClient for graceful shutdown #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prabhjot-Sethi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Close() to mongoClient for graceful shutdown #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions db/mongo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,3 +555,10 @@ func (c *mongoClient) GetCollection(dbName, col string) StoreCollection {
func (c *mongoClient) HealthCheck(ctx context.Context) error {
return c.client.Ping(ctx, nil)
}

// Close disconnects the underlying MongoDB driver client, releasing its
// connection pool. Implements io.Closer so callers can type-assert
// StoreClient to io.Closer for graceful shutdown.
func (c *mongoClient) Close() error {
return c.client.Disconnect(context.Background())
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add a deadline when disconnecting Mongo client

Close() calls Disconnect(context.Background()), but Mongo driver's Disconnect waits for in-use connections to be returned and only stops waiting when the context is canceled/deadlined. In shutdown paths with a stuck/leaked DB operation, this can block indefinitely and prevent graceful process termination; using a bounded timeout context inside Close() avoids hanging services while still releasing the pool in normal cases.

Useful? React with 👍 / 👎.

}