feat: Add support for unevaluatedProperties in JSON Schema#2800
Open
haya14busa wants to merge 1 commit intoglideapps:masterfrom
Open
feat: Add support for unevaluatedProperties in JSON Schema#2800haya14busa wants to merge 1 commit intoglideapps:masterfrom
haya14busa wants to merge 1 commit intoglideapps:masterfrom
Conversation
Add support for the unevaluatedProperties keyword from JSON Schema draft 2019-09/2020-12.
When additionalProperties is not defined, unevaluatedProperties is now used as a fallback
to determine the type of additional properties in an object.
This fixes issues where objects using unevaluatedProperties would generate incorrect
types (e.g., map[string]interface{} instead of properly typed maps in Go).
dd63fbd to
af0c9ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
unevaluatedPropertieskeyword from JSON Schema draft 2019-09/2020-12.Problem
When using JSON Schema with
unevaluatedProperties, quicktype was generating incorrect types. For example, in Go, it would generatemap[string]interface{}instead of properly typed maps likemap[string][]SomeType.Solution
When
additionalPropertiesis not defined in a schema, quicktype now falls back to usingunevaluatedPropertiesto determine the type of additional properties in an object.Changes
JSONSchemaInput.tsto handleunevaluatedPropertieswhenadditionalPropertiesis undefinedunevaluatedPropertiesTest
Added test schema and data files:
test/inputs/schema/unevaluated-properties.schematest/inputs/schema/unevaluated-properties.1.jsontest/inputs/schema/unevaluated-properties.2.jsonThe tests can be run with:
QUICKTEST=true FIXTURE=schema-golang npm testExample
Before this fix:
After this fix: