feat: add separator, line numbers and view toggle#41
feat: add separator, line numbers and view toggle#41shatrughantwt wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: shatrughan mishra <shatrughanm485@gmail.com>
There was a problem hiding this comment.
feedback from QA:
- The line numbers are too close to the actual text, there should be a gap
- When a line becomes too long (check the screenshot attached) it seems to be wrapping around and breaking the vertical divider
- The color of the divider does not match the color of the panel borders
- You have to press
ctrl+dtwice while in split diff view mode to change to unified currently, it should only take one click, probably some issue with how the update function was modified - Also the colors of text in split diff view and unified diff view are not consistent
Signed-off-by: shatrughan mishra <shatrughanm485@gmail.com>
|
help me with the vertical divider issue |
I'll get to this by this weekend. |
Signed-off-by: shatrughan mishra <shatrughanm485@gmail.com>
|
i fixed strings.Fields issue after that still shows broken in big diff |
|
when will you review c9b50ba |
I'll get to this by tomorrow! EDIT: I did a quick QA and looked up the code, its probably that lipgloss's layout management is just not reliable for our usecase. Also, I just noticed github's split view diff when handling soft wrap cap is already similar to ours, so we just need to fix the broken vertical spacer issue. Since you are having trouble with this one I'll try to push a fix for this. |
|
marking this PR as a draft, split view feature is to be abandoned for now, will look into this later. |



Description
Follow-up PR to further enhance the diff viewer with improved layout and usability.
Changes
splitViewThresholdResult
Cleaner split layout, improved readability and better overall user experience.