Merge 432

[decyjphr]

Merge PR #432 and also fix some log errors

[Copilot]

Pull Request Overview

This PR merges PR #432 and fixes some logging issues while updating several configuration variable names and patterns. Key changes include:

• Renaming Settings.FILE_NAME to Settings.FILE_PATH and updating corresponding tests.
• Replacing standard log calls with debug-level log calls in multiple plugins.
• Renaming the deployment config environment variable from DEPLOYMENT_CONFIG_FILE to DEPLOYMENT_CONFIG_FILE_PATH.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
lib/settings.js	Updated constant name from FILE_NAME to FILE_PATH; added glob patterns.
lib/plugins/rulesets.js and lib/plugins/validator.js	Replaced log calls with debug-level log calls.
lib/env.js	Renamed DEPLOYMENT_CONFIG_FILE to DEPLOYMENT_CONFIG_FILE_PATH.
index.js	Updated references to use the new settings and env variable names.
Test files (integration/unit)	Updated test endpoints and expectations to reflect the new names.
lib/deploymentConfig.js	Adjusted configuration file path retrieval using the new env variable.
lib/plugins/branches.js	Changed log calls to debug for branch protection messages.

Comments suppressed due to low confidence (3)

lib/settings.js:911

• [nitpick] Consider adding inline documentation to explain the purpose of the newly introduced FILE_PATH, SUB_ORG_PATTERN, and REPO_PATTERN properties, to aid future maintenance.

Settings.FILE_PATH = path.posix.join(CONFIG_PATH, env.SETTINGS_FILE_PATH)

lib/env.js:5

• Ensure that any external references and developer documentation are updated to reflect the new DEPLOYMENT_CONFIG_FILE_PATH name, instead of the old DEPLOYMENT_CONFIG_FILE.

DEPLOYMENT_CONFIG_FILE_PATH: process.env.DEPLOYMENT_CONFIG_FILE || 'deployment-settings.yml',

test/integration/plugins/milestones.test.js:24

• Verify that all tests have been updated to consistently use FILE_PATH in place of FILE_NAME, ensuring no discrepancies between production code and tests.

.get(`/repos/${repository.owner.name}/${repository.name}/contents/${settings.FILE_PATH}`)

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more