Refactor dead helpers and trivial guard wrappers; consolidate session ID utility#7279
Draft
Copilot wants to merge 3 commits into
Draft
Refactor dead helpers and trivial guard wrappers; consolidate session ID utility#7279Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
6 tasks
Copilot
AI
changed the title
[WIP] Refactor semantic function clustering analysis for dead code and wrappers
Refactor dead helpers and trivial guard wrappers; consolidate session ID utility
Jun 9, 2026
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static analysis flagged dead production helpers in
logger, no-op wrapper indirection inguard, and a single-function micro-file inserver. This PR removes unused code paths and trims indirection without changing runtime behavior.Logger cleanup (dead production code)
extractEssentialFieldsfrominternal/logger/rpc_helpers.go(unused in prod and tests after refactor).internal/logger/log_cleanup.goand moved its message-normalization helper into test-only scope (internal/logger/log_cleanup_test.go).internal/logger/rpc_helpers_test.goto match test-only helper naming and removed obsoleteextractEssentialFieldstests.Guard policy validation (wrapper inlining)
internal/guard/wasm_validate.go:validateStringArray(...)isValidAllowOnlyRepos(...)internal/guard/wasm_payload.gowith directconfigpackage calls.configvalidators directly.Server utility consolidation
truncateSessionIDintointernal/server/session.go.internal/server/session_util.go.