Refactor launcher connection error logging into internal/launcher#7276
Draft
Copilot wants to merge 2 commits into
Draft
Refactor launcher connection error logging into internal/launcher#7276Copilot wants to merge 2 commits into
internal/launcher#7276Copilot wants to merge 2 commits into
Conversation
7 tasks
Copilot
AI
changed the title
[WIP] Fix duplicate code pattern in launcher log prefix
Refactor launcher connection error logging into Jun 9, 2026
internal/launcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[LAUNCHER]-prefixed connection failure logs were split acrossinternal/mcpandinternal/launcher, which blurred ownership and made launcher log behavior harder to find and evolve. This change consolidates launcher-specific error diagnostics in the launcher package and removes launcher-prefixed behavior from mcp internals.Logging ownership realignment
internal/launcher/connection_error_log.gowith:ConnectionErrorContextLogConnectionError[LAUNCHER]connection-failure formatting and hint logic into the launcher subsystem.Launcher call-site update
internal/launcher/log_helpers.go:logLaunchErrornow invokes launcher-localLogConnectionError(...)mcp.ConnectionErrorContext/mcp.LogConnectionError.mcp package decoupling
internal/mcp/connection_logging.go.internal/mcp/connection.goconnection-failure branch to emit mcp-scoped structured errors (including sanitized stderr) without[LAUNCHER]console conventions.Test ownership alignment
internal/mcp/errors_test.gotointernal/launcher/connection_error_log_test.goso behavior coverage lives with the owning package.