Prepare v0.9.0: fix build, harden inputs, add e2e + release workflow#7
Merged
Prepare v0.9.0: fix build, harden inputs, add e2e + release workflow#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare v0.9.0: fix the broken
make programbuild (linker error nevercaught because CI only ran
make gtests), validate CLI inputs, add a releaseworkflow and end-to-end tests, and bump
cxxoptsto v3.3.1.Changes
inlineUtils helpers to fix duplicate-symbol link error; CI nowbuilds the binary on every platform;
-std=c++17 -O2 -Wall -Wextra.--mtu/--port/--bind-port/--ttl/--type/--broadcast; cap announced file size at 4 GiB;inet_ptoninstead of
inet_addr;int(notchar) for Winsock options; bail outcleanly on
FINISHwithoutNEW_PACKET; checkoutput.writeandsendto;nothrowallocations;WSACleanupon every error path; fix signed overflowon > 2 GiB files.
--bind-port(separates listen port from destination port),--version,--help..github/workflows/release.ymlbuilds Linux / macOS arm64 /Windows binaries on
v*tags and attaches them to a GitHub Release.tests/e2e.shruns sender + receiver on loopback, verifiesbit-identical round-trip for 50 KiB and 2 MiB files; CI runs it on Linux
and macOS (skipped on Windows — Winsock
SO_REUSEADDRsemantics).cxxoptsv2.1.1 → v3.3.1.instructions).