feat(github): Add issue types support for Sentry issues#111501
feat(github): Add issue types support for Sentry issues#111501Asynchronite wants to merge 24 commits intogetsentry:masterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
cvxluo
added
the
Trigger: getsentry tests
|
Does the team who usually reviews this get automatically notified or..? |
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
some nits w/ naming but otherwise looks fine -- this needs some frontend work though to actually add it to the modal I think?
Note: We split FE and BE work in separate PRs |
|
@billyvg @bruno-garcia Implemented both of your changes, thanks for the suggestions (If one of you would be so kind as to re-review and trigger the |
github-actions
bot
removed
the
Trigger: getsentry tests
Frontend work is not really my domain, though if you can point me to the repo/code which houses this stuff I can def. look into it! |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
bruno-garcia
added
the
Trigger: getsentry tests
|
Thank you! Retriggered CI. Team will take a look next week |
@kenzoengineer @joshuarli @hubertdeng123 from Discord, any clue? I'm just here to forward the message |
|
@bruno-garcia Related to the above, should I look into fixing the codeowners stuff or no? |
|
i assume the env is |
Done that it keeps trying to pull getsentry. I'd like to start clean but I'mma need some help with that. |
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
don't worry about the CODEOWNERS job
| responses.add( | ||
| responses.GET, | ||
| "https://api.github.com/orgs/getsentry/issue-types", | ||
| json=[{"name": "bug"}, {"name": "task"}], | ||
| ) |
There was a problem hiding this comment.
there are no assertions that these issue types exist in the config below
There was a problem hiding this comment.
What do you want me to do here then, I do not think I have access to this info since I am not a member of the org.
There was a problem hiding this comment.
@Asynchronite the tests below don't check that we have the new issue type field, see lines 99-107. these values should map to https://github.com/getsentry/sentry/pull/111501/changes#diff-ddf35fe3e7025def70c1031006058afeb7f7cb271b82295b5a2729946e8cb329R225-R233
we should also add a test somewhere for the issue type values from the response mock (bug and task)
There was a problem hiding this comment.
@Asynchronite the tests below don't check that we have the new issue type field, see lines 99-107. these values should map to #111501 (changes)
we should also add a test somewhere for the issue type values from the response mock (
bugandtask)
That's very strange, there haven't been any changes to that codepath recently. What directory are you running the command in? Have you tried both exporting and inlining it? # 2 liner
export SENTRY_EXTERNAL_CONTRIBUTOR="1"
devenv fetch sentry
# 1 liner
SENTRY_EXTERNAL_CONTRIBUTOR="1" devenv fetch sentryalso maybe try |
|
@kenzoengineer Hey, I will get back to you when I get a chance, currently away from the computer I used to do this. Sorry for the inconvenience! |
Okay, when going through the docs and the instructions inside the CLI, it did not mentiuon that After setting it, it worked. Thank you! |
|
Made the docs more clear so hopefully nobody will be tripped up on the same thing :D getsentry/devenv#228 |
…y try-except block
github-actions
bot
removed
the
Trigger: getsentry tests
|
If someone would be oh-so-kind as to trigger getsentry tests I would appreciate it! |
billyvg
added
the
Trigger: getsentry tests
|
@Asynchronite ok so the code looks good but as I was testing it locally, I realized we have a problem in that the Sentry GitHub App needs specific permissions to read Issue Types 
Changing this on our app will send out notifications to all of our customers who have it installed, prompting them to update. Unfortunately, I don't think I can sell our team on doing that for this feature :'( |
6 participants
This PR introduces the addition of types to the modal that opens when you try to link a GitHub issue to an external code tracking software.
An example of issue types:
Closes #111404.
@cvxluo
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.