Replace with direct run step#52
Open
mendral-app[bot] wants to merge 1 commit into
Open
Conversation
Remove third-party cloudflare/wrangler-action and replace with a direct npx wrangler command. Wrangler is already installed via npm ci as a project dependency. This eliminates supply chain risk from the third-party action and resolves the Node.js 20 deprecation warning it was emitting. Also removes the now-unused deployments:write permission which was only needed by the action's GitHub deployment status feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudflare/wrangler-actionwith a directnpx wrangler pages deployrun step, eliminating supply chain risk and the Node.js 20 deprecation warningdeployments: writepermission (was only needed by the action's GitHub deployment status feature)Changes
.github/workflows/deploy.yamlBefore:
After:
Wrangler is already installed as a project dependency via
npm ci, so no additional setup is needed. TheCLOUDFLARE_API_TOKENandCLOUDFLARE_ACCOUNT_IDenvironment variables are read natively by wrangler.Notes
gitHubTokeninput was used by the action to create GitHub deployment status entries. This is no longer set. If deployment status tracking is desired, it can be added separately.deployments: writepermission was only needed for that feature and has been removed.Related insight: Deploy workflow uses third-party cloudflare/wrangler-action
Note
Created by Mendral. Tag @mendral-app with feedback or questions.