Skip to content

Add Dockerfile for Selen#10

Open
JarettBakerDunn wants to merge 1 commit intogeodynamics:masterfrom
JarettBakerDunn:docker
Open

Add Dockerfile for Selen#10
JarettBakerDunn wants to merge 1 commit intogeodynamics:masterfrom
JarettBakerDunn:docker

Conversation

@JarettBakerDunn
Copy link
Copy Markdown

docker/selen contains a Dockerfile to build an image which hosts a built copy of selen. The image is also hosted at geodynamics/selen on Dockerhub.

Copy link
Copy Markdown
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gassmoeller
Copy link
Copy Markdown
Member

The file looks correct but the tester is crashing. It looks like the selen-buildenv container that is used for the tests is still using Ubuntu 18.04. Could you try updating the selen-buildenv container, upload a new tester image to docker hub and check if the tests pass then?

@JarettBakerDunn
Copy link
Copy Markdown
Author

JarettBakerDunn commented Sep 25, 2024

hm, I pushed a new image of selen-buildenv to dockerhub, but it doesn't seem like I'm able to manually run the "linux" test action. I might not have the permissions for it.

@gassmoeller
Copy link
Copy Markdown
Member

Seems to be all working now. Can you include the changes you made to the buildenv dockerfile to this PR?

@gassmoeller
Copy link
Copy Markdown
Member

For the future: Even if you do not have the permissions to trigger the test run again, you can always amend your commit without changing anything (git commit --amend) and then force push to your branch on github. This doesnt change anything, but will retrigger the tests on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants