Skip to content

feat(plugins/google-genai/vertexai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations#5457

Open
ecaroth wants to merge 2 commits into
genkit-ai:mainfrom
match2-jobs:match2/vertexai-multi-regional
Open

feat(plugins/google-genai/vertexai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations#5457
ecaroth wants to merge 2 commits into
genkit-ai:mainfrom
match2-jobs:match2/vertexai-multi-regional

Conversation

@ecaroth

@ecaroth ecaroth commented Jun 4, 2026

Copy link
Copy Markdown

VertexAI (renamed to Enterprise Agent Platform by google) supports multi-regional endpoints that have different base location URLs than were currently supported. This PR addresses support for that, and also allows specifically setting the api version (to v1 or v1beta1 ... was hardcoded to v1beta1 before)

Checklist (if applicable):

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Jun 4, 2026
@google-cla

google-cla Bot commented Jun 4, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added the js label Jun 4, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for multi-regional endpoints and configurable API versions in the Vertex AI plugin, updating URL generation, client options, and option derivation utilities alongside new unit tests. The review feedback identifies a syntax error and recommends using placeholder constants in the documentation, corrects typos in error messages and corresponding test assertions, and suggests renaming a utility function to follow standard camelCase casing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread js/plugins/google-genai/README.md Outdated
Comment thread js/plugins/google-genai/src/vertexai/client.ts Outdated
Comment thread js/plugins/google-genai/tests/vertexai/client_test.ts Outdated
Comment thread js/plugins/google-genai/src/vertexai/utils.ts Outdated
Comment thread js/plugins/google-genai/src/vertexai/utils.ts Outdated
Comment thread js/plugins/google-genai/src/vertexai/utils.ts Outdated
@ecaroth ecaroth force-pushed the match2/vertexai-multi-regional branch 2 times, most recently from 0be3162 to 08890c3 Compare June 4, 2026 23:13
@ecaroth ecaroth force-pushed the match2/vertexai-multi-regional branch from 08890c3 to 129d00c Compare June 4, 2026 23:15
@ecaroth ecaroth changed the title Updates to google-genai/vertexai to support apiVersion and multi-regional locations feat: Updates to google-genai/vertexai to support apiVersion and multi-regional locations Jun 4, 2026
@ecaroth ecaroth changed the title feat: Updates to google-genai/vertexai to support apiVersion and multi-regional locations feat(plugins/google-genai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations Jun 4, 2026
@ecaroth ecaroth changed the title feat(plugins/google-genai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations feat(plugins/google-genai/vertexai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations Jun 5, 2026
@NicolasMahe

Copy link
Copy Markdown

I'm also affected by this issue.

My project currently uses the global Vertex AI endpoint, but I'd like to switch to the eu multi-regional endpoint, and the current implementation doesn't appear to support it correctly. This PR would unblock my use case and allow me to use multi-region deployments.

Thanks @ecaroth for working on this — I'd definitely benefit from seeing it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation js

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants