feat(plugins/google-genai/vertexai): Updates to google-genai/vertexai to support apiVersion and multi-regional locations#5457
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for multi-regional endpoints and configurable API versions in the Vertex AI plugin, updating URL generation, client options, and option derivation utilities alongside new unit tests. The review feedback identifies a syntax error and recommends using placeholder constants in the documentation, corrects typos in error messages and corresponding test assertions, and suggests renaming a utility function to follow standard camelCase casing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
0be3162 to
08890c3
Compare
08890c3 to
129d00c
Compare
|
I'm also affected by this issue. My project currently uses the global Vertex AI endpoint, but I'd like to switch to the eu multi-regional endpoint, and the current implementation doesn't appear to support it correctly. This PR would unblock my use case and allow me to use multi-region deployments. Thanks @ecaroth for working on this — I'd definitely benefit from seeing it merged. |
VertexAI (renamed to Enterprise Agent Platform by google) supports multi-regional endpoints that have different base location URLs than were currently supported. This PR addresses support for that, and also allows specifically setting the api version (to
v1orv1beta1... was hardcoded tov1beta1before)Checklist (if applicable):