Skip to content

Use eza instead of exa#54

Open
dieggsy wants to merge 2 commits into
gazorby:mainfrom
dieggsy:main
Open

Use eza instead of exa#54
dieggsy wants to merge 2 commits into
gazorby:mainfrom
dieggsy:main

Conversation

@dieggsy
Copy link
Copy Markdown

@dieggsy dieggsy commented Jan 28, 2025

Exa is no longer maintained.

Exa is no longer maintained.
@imroc
Copy link
Copy Markdown

imroc commented Jun 19, 2025

+1

@vdawg-git
Copy link
Copy Markdown

Can this get merged? :)

Copy link
Copy Markdown
Owner

@gazorby gazorby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Left few comments, but would be happy to merge this!

exa --color=always $fifc_exa_opts $fifc_candidate
if type -q eza
eza --color=always $fifc_eza_opts $fifc_candidate
else
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add an exa fallback here, to not break compatibility

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I guess I should keep around fifc_exa_opts too in that case?

@dieggsy
Copy link
Copy Markdown
Author

dieggsy commented Aug 7, 2025

Ok, I kept around the exa code in an else if for compatibility

@vdawg-git
Copy link
Copy Markdown

Just bumping again.
@dieggsy can you do a quick format? Maybe thats why gazorby is not merging it

@dieggsy
Copy link
Copy Markdown
Author

dieggsy commented Sep 18, 2025

@vdawg-git I'm not sure what the actual format failure is due to; ideas?

@bea231
Copy link
Copy Markdown

bea231 commented Oct 15, 2025

@vdawg-git I'm not sure what the actual format failure is due to; ideas?

It seems like /home/runner/work/fifc/fifc/tests/test_exposed_vars.fish test is failing for some reason

adam01110 added a commit to adam01110/FzFish that referenced this pull request Mar 13, 2026
xxxbrian added a commit to xxxbrian/fzf-tab.fish that referenced this pull request Mar 26, 2026
Import upstream PR gazorby#54: use eza fallback chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants