Skip to content

beacon chain state transition init#10

Open
ninaiiad wants to merge 4 commits intomainfrom
ng/bsi-sq
Open

beacon chain state transition init#10
ninaiiad wants to merge 4 commits intomainfrom
ng/bsi-sq

Conversation

@ninaiiad
Copy link
Copy Markdown
Collaborator

No description provided.

}

impl Tile<SilverSpine> for BeaconStateTile {
fn loop_body(&mut self, adapter: &mut SpineAdapter<SilverSpine>) {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start here

Comment thread crates/common/src/spine/messages.rs
Comment thread crates/beacon_state/src/tile.rs
Comment thread crates/beacon_state/src/tile.rs Outdated
Comment thread crates/common/src/spine/messages.rs
Comment thread crates/common/src/spine/messages.rs
Comment thread crates/beacon_state/src/tile.rs Outdated
Comment thread crates/beacon_state/src/tile.rs Outdated
Comment thread crates/beacon_state/src/tile.rs
Comment thread crates/beacon_state/src/tile.rs
Comment thread crates/beacon_state/src/state_transition.rs
Comment thread crates/beacon_state/src/state_transition.rs
Comment thread crates/common/src/ssz_view.rs

let mut active_scratch = Vec::new();
let mut postponed_scratch = Vec::new();
if block_slot > sd.slot {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point this block_slot is raw data received from the internet. We should sanity check against an internal clock first before using it. Also, we should maybe move the sig check above this so we only act on data received from a valid source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants