fix(dashboard): stabilize scope-banner height across overseer states#1805
Open
jonathanpberger wants to merge 1 commit intogastownhall:mainfrom
Open
fix(dashboard): stabilize scope-banner height across overseer states#1805jonathanpberger wants to merge 1 commit intogastownhall:mainfrom
jonathanpberger wants to merge 1 commit intogastownhall:mainfrom
Conversation
Two causes of height jiggle: 1. renderCityScopeBanner rendered 2 stats (no overseer) vs 5 stats (overseer present), making the right side change visual width. 2. The Activity stat timestamp could wrap at narrower viewports, making that stat taller and the banner grow. Fix: always render all 5 stats; use "—" placeholders when no overseer is active. Add white-space: nowrap to .scope-stat-value to prevent wrapping. Closes gastownhall#1804. Co-Authored-By: RubyBear (<synthetic>) <noreply@anthropic.com>
github-actions
Bot
added
the
status/needs-triage
randy-release-manager
Bot
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderCityScopeBanner(was 2 when no overseer, 5 when present)"—"placeholder values for unavailable fields when no overseer session existswhite-space: nowrapto.scope-stat-valueto prevent Activity timestamps wrapping to a second lineCloses #1804.
Test plan
npm run test)renders all five scope stats when no overseer session existsconfirms consistent stat countNeed help on this PR? Tag
@codesmithwith what you need.