Skip to content

fix(pool): create sessions with concrete identity#1784

Open
julianknutsen wants to merge 1 commit intomainfrom
fix/pool-create-concrete-identity
Open

fix(pool): create sessions with concrete identity#1784
julianknutsen wants to merge 1 commit intomainfrom
fix/pool-create-concrete-identity

Conversation

@julianknutsen
Copy link
Copy Markdown
Collaborator

@julianknutsen julianknutsen commented May 7, 2026

Summary

  • create new pool session beads with their concrete slot identity immediately
  • stamp agent_name, alias, pool_slot, title, and agent label consistently at creation time
  • keep existing fallback behavior for callers that do not know a concrete pool identity

Tests

  • go test ./cmd/gc -run 'TestBuildDesiredState_NewPoolSessionBeadCreatedWithConcreteIdentity|TestBuildDesiredState_RoutedQueueDoesNotCreateOneSessionPerBead|TestSelectOrCreatePoolSessionBead|TestSelectOrCreateDependencyPoolSessionBead|TestPoolSessionName|TestCreatePoolSessionBead' -count=1
  • go test ./cmd/gc -count=1
  • pre-commit quality gate during commit: lint, vet, observable go test

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@julianknutsen julianknutsen added status/needs-review-auto PR review requested with auto approval status/reviewing and removed status/needs-review-auto PR review requested with auto approval labels May 7, 2026
@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label May 7, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

❌ Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/gc/build_desired_state.go 70.96% 5 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@randy-release-manager randy-release-manager Bot added kind/bug Broken behavior priority/p2 Medium — real problem, workaround exists and removed status/needs-triage Inbox — we haven't looked at it yet labels May 7, 2026
@blacksmith-sh
Copy link
Copy Markdown

blacksmith-sh Bot commented May 7, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
github.com/gastownhall/gascity/cmd/gc/
TestCityRuntimeManualReloadReplyWaitsForTickCompletion
View Logs

Fix with Codesmith
Need help on this PR? Tag @codesmith with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Broken behavior priority/p2 Medium — real problem, workaround exists status/reviewing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants