Skip to content

fix(session): roll back canceled pending creates#1782

Open
julianknutsen wants to merge 1 commit intomainfrom
fix/pending-create-stop-fixes
Open

fix(session): roll back canceled pending creates#1782
julianknutsen wants to merge 1 commit intomainfrom
fix/pending-create-stop-fixes

Conversation

@julianknutsen
Copy link
Copy Markdown
Collaborator

@julianknutsen julianknutsen commented May 7, 2026

Summary

  • Roll back pending-create session beads when an async start succeeds but the controller context is canceled before commit.
  • Avoid stamping city-stop sleep metadata onto creating sessions; create rollback owns that state.

Tests

  • go test ./cmd/gc -run 'TestMarkCityStopSessionSleepReasonSkipsCreatingSessions|TestCommitAsyncStartResultWithContext_(SkipsCanceledCommit|StopsCanceledSuccessfulPendingCreateRuntime|RollsBackCanceledPendingCreateSuccess|RollsBackCanceledPendingCreateError)' -count=1
  • pre-commit hook: go test -json -p=4 -count=1 ./...

View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@julianknutsen julianknutsen added the status/needs-review-auto PR review requested with auto approval label May 7, 2026
@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label May 7, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@randy-release-manager randy-release-manager Bot added kind/bug Broken behavior priority/p2 Medium — real problem, workaround exists and removed status/needs-triage Inbox — we haven't looked at it yet labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Broken behavior priority/p2 Medium — real problem, workaround exists status/needs-review-auto PR review requested with auto approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants