Skip to content

fix(packs): cover remaining gc session peek line-count syntax#1779

Open
julianknutsen wants to merge 1 commit intomainfrom
pr-review/ga-sgs0wa-followup
Open

fix(packs): cover remaining gc session peek line-count syntax#1779
julianknutsen wants to merge 1 commit intomainfrom
pr-review/ga-sgs0wa-followup

Conversation

@julianknutsen
Copy link
Copy Markdown
Collaborator

@julianknutsen julianknutsen commented May 7, 2026

Maintainer follow-up for PR #1768

Original PR: #1768
Original title: fix(packs): use --lines flag for gc session peek (witness template)
Original state: MERGED
Configured base branch: main
Original GitHub base: main
Base mismatch: none

PR #1768 fixed the witness prompt's gc session peek usage after the CLI moved line counts to the --lines flag. The review found the same syntax pattern in nearby pack surfaces and requested a regression guard so this command-shape drift does not recur.

This follow-up contains only maintainer-side review fixes:

  • update the remaining deacon prompt example to gc session peek <target> --lines 50
  • update the shutdown-dance formula's gc session peek calls to use --lines
  • add a focused packlint regression test for positional gc session peek <target> <n> syntax under examples/

This preserves the original contribution from #1768 and carries the maintainer-side review fixes through a separate merge surface because the original PR had already merged before finalization.


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label May 7, 2026
@randy-release-manager randy-release-manager Bot added kind/chore Internal improvement (refactor, tests, CI, tooling) priority/p3 Backlog — good idea, reviewed when there's bandwidth and removed status/needs-triage Inbox — we haven't looked at it yet labels May 7, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@blacksmith-sh

This comment has been minimized.

@julianknutsen julianknutsen added the status/needs-review-auto PR review requested with auto approval label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore Internal improvement (refactor, tests, CI, tooling) priority/p3 Backlog — good idea, reviewed when there's bandwidth status/needs-review-auto PR review requested with auto approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants