fix(packs): cover remaining gc session peek line-count syntax#1779
Open
julianknutsen wants to merge 1 commit intomainfrom
Open
fix(packs): cover remaining gc session peek line-count syntax#1779julianknutsen wants to merge 1 commit intomainfrom
julianknutsen wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer follow-up for PR #1768
Original PR: #1768
Original title: fix(packs): use --lines flag for gc session peek (witness template)
Original state: MERGED
Configured base branch: main
Original GitHub base: main
Base mismatch: none
PR #1768 fixed the witness prompt's
gc session peekusage after the CLI moved line counts to the--linesflag. The review found the same syntax pattern in nearby pack surfaces and requested a regression guard so this command-shape drift does not recur.This follow-up contains only maintainer-side review fixes:
gc session peek <target> --lines 50gc session peekcalls to use--linesgc session peek <target> <n>syntax underexamples/This preserves the original contribution from #1768 and carries the maintainer-side review fixes through a separate merge surface because the original PR had already merged before finalization.
Need help on this PR? Tag
@codesmithwith what you need.