fix: fall back to provider state when managed dolt is unpublished#1766
Open
azanar wants to merge 1 commit intogastownhall:mainfrom
Open
fix: fall back to provider state when managed dolt is unpublished#1766azanar wants to merge 1 commit intogastownhall:mainfrom
azanar wants to merge 1 commit intogastownhall:mainfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This teaches GC-managed Dolt target resolution to fall back to valid provider runtime state when the published managed-Dolt state file is still missing.
What changed
currentResolvableManagedDoltPort()to prefer published runtime state but fall back to valid provider runtime stateresolvedRuntimeCityDoltTarget()to use that provider-state port during recovery when the canonical managed target is still unpublishedWhy
There is a startup window where managed Dolt is already running and provider state is valid, but the published runtime state file is not present yet. During that window, GC-managed startup paths could still resolve a local managed target without a port and fall through to
127.0.0.1:0failures.This keeps the target resolution aligned with the real managed runtime state during that gap.
Tests
go test ./cmd/gc -run 'TestBdRuntimeEnv(DoesNotUseStalePortFileWithoutManagedRuntimeState|UsesValidProviderStateWhenPublishedStateIsMissing)' -count=1Need help on this PR? Tag
@codesmithwith what you need.