Moved "react-dom-factories" and "react-transition-group" from peerDep…#170
Open
christiantinauer wants to merge 1 commit intofurqanZafar:masterfrom
Open
Moved "react-dom-factories" and "react-transition-group" from peerDep…#170christiantinauer wants to merge 1 commit intofurqanZafar:masterfrom
christiantinauer wants to merge 1 commit intofurqanZafar:masterfrom
Conversation
…s to deps, because they are used to make react-selectize work in production. PeerDependencies force the user to also use the same exact versions, which is problem with react-transition-group (v1 and v2 do exist).
|
+1 |
|
Can someone please approve this pull request? I cannot use react-selectize with React 16 as the dependencies force me to have React 15 also. Thanks |
|
This pull request is now open for more than one month, without comment from the project owners. This is not ok for a library I want to use in production. Is this project still under maintenance? |
|
I published a fork with this fixed: https://www.npmjs.com/package/@benbria/react-selectize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s to deps, because they are used to make react-selectize work in production. PeerDependencies force the user to also use the same exact versions, which is a problem with react-transition-group (v1 and v2 do exist).