mobile: gate all c.bl.* blockchain methods through beginOp (#242)#243
Merged
Conversation
The ~40 blockchain/hardware methods on the mobile Client called c.bl.X(context.TODO(), c.bloxPid, ...) with no closed-check, so an in-flight read (BloxFreeSpace/GetFolderSize/ListActivePlugins/...) could run concurrently with Shutdown() and nil-deref the torn-down client -> Go SIGSEGV (addr=0xb8) -> SIGABRT. #241's beginOp/inflight-drain gate covered only ConnectToBlox/Ping. Route all 44 c.bl.* methods through beginOp(): once Shutdown has set closed, calls return ErrClientClosed instead of dereferencing freed state; otherwise they register in inflight so Shutdown drains them (and opCancel cancels them) before closing the host/datastore. ReplicateInPool returns an error-JSON on closed (bare []byte signature); ChatWithAI gates the setup call but keeps context.TODO() for the streaming buffer that outlives the call. Test: TestBlockchainMethodsAfterShutdownReturnErrClosed asserts the blockchain reads named in the crash log return ErrClientClosed after Shutdown. Verified to reproduce the production nil-deref panic when the gate is removed, and pass with it. go build + go vet clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ~40 blockchain/hardware methods on the mobile Client called c.bl.X(context.TODO(), c.bloxPid, ...) with no closed-check, so an in-flight read (BloxFreeSpace/GetFolderSize/ListActivePlugins/...) could run concurrently with Shutdown() and nil-deref the torn-down client -> Go SIGSEGV (addr=0xb8) -> SIGABRT. #241's beginOp/inflight-drain gate covered only ConnectToBlox/Ping.
Route all 44 c.bl.* methods through beginOp(): once Shutdown has set closed, calls return ErrClientClosed instead of dereferencing freed state; otherwise they register in inflight so Shutdown drains them (and opCancel cancels them) before closing the host/datastore. ReplicateInPool returns an error-JSON on closed (bare []byte signature); ChatWithAI gates the setup call but keeps context.TODO() for the streaming buffer that outlives the call.
Test: TestBlockchainMethodsAfterShutdownReturnErrClosed asserts the blockchain reads named in the crash log return ErrClientClosed after Shutdown. Verified to reproduce the production nil-deref panic when the gate is removed, and pass with it. go build + go vet clean.