Improve typings by adding strict tsconfig.json#363
Open
fnune wants to merge 4 commits intofullstackreact:masterfrom
Open
Improve typings by adding strict tsconfig.json#363fnune wants to merge 4 commits intofullstackreact:masterfrom
fnune wants to merge 4 commits intofullstackreact:masterfrom
Conversation
Running `npm run typecheck` will run the TypeScript compiler without emitting files to check for type errors in index.d.ts
Due to strict mode on ES5 having a syntax error for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
npm run typecheckwill run the TypeScript compiler without emitting files to check for type errors in index.d.tsThis PR will make
google-maps-reactcompile properly in projects that use thestricttsconfig flag, and it won't break existing projects.