[Repo Assist] fix: dispose SHA1 instance in Caching.hashString; use SHA1.HashData on .NET 5+#1745
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
…n .NET 5+ On netstandard2.0, SHA1.Create() returns a HashAlgorithm (IDisposable) that was never disposed — a small but genuine resource leak. On .NET 5+, use the static SHA1.HashData(byte[]) method which avoids creating a disposable instance entirely and is the idiomatic modern API. On netstandard2.0, wrap the instance in 'use' to ensure deterministic disposal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
Fixes a resource leak in
Caching.fs—SHA1.Create()returned aHashAlgorithm(IDisposable) that was never disposed.Before
After
Details
SHA1instance inusefor deterministic disposal — this is theHashAlgorithm.Dispose()path that frees any unmanaged resources.SHA1.HashData(byte[]), the static API introduced in .NET 5 that avoids creating a disposable object entirely. This is the idiomatic modern approach.hashStringis called only at design-time (to derive a cache file name from a URL), so the performance impact is negligible — the value here is correctness and clean resource handling.Test Status
dotnet build src/FSharp.Data.Runtime.Utilities/— 0 errorsdotnet test tests/FSharp.Data.Core.Tests/— 2920 passed, 0 failed