Album (and some settings) improvements#314
Merged
Conversation
…r selectAll button container; changed color of select textbutton (in appBar)
…h improved and simplified caching); improved imageBrowser to show thumbnail while loading fullsize image as well as keeping pages alive for longer; reduced usage of futures; minor improvements
MikaeldeVerdier
added
bug
marksam32
requested changes
May 6, 2026
Contributor
marksam32
left a comment
marksam32
left a comment
There was a problem hiding this comment.
Overall good! Just these things that I found
Contributor
Author
|
Good catch, should be fixed now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed select and download images. Improved image browser by now showing thumbnail while loading and preloading adjacent images. Reduced amount of futures used and implemented an images_service singleton to fetch all images. Fixed "unsaved changes" dialog box in settings.