feat: add insecureUnsafeInline option to CSP middleware#3841
Closed
SisyphusZheng wants to merge 3 commits into
Closed
feat: add insecureUnsafeInline option to CSP middleware#3841SisyphusZheng wants to merge 3 commits into
SisyphusZheng wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When useNonce: true, the CSP middleware replaces all 'unsafe-inline' occurrences with 'nonce-{value}'. Users who need both Fresh's nonce-based inline scripts AND third-party inline scripts (analytics, reporting widgets) cannot achieve this — the current middleware completely removes 'unsafe-inline'.
Solution
Add insecureUnsafeInline?: boolean option. When enabled with useNonce: true, retains 'unsafe-inline' alongside the nonce:
script-src 'self' 'unsafe-inline' 'nonce-deadbeef42'When useNonce is false, the option has no effect.
Changes
Verification
deno test -A packages/fresh/src/middlewares/csp_test.tsx — 13 passed, 0 failed