docs: recommend --lock-write over manual lockfile editing#3839
Open
SisyphusZheng wants to merge 1 commit into
Open
docs: recommend --lock-write over manual lockfile editing#3839SisyphusZheng wants to merge 1 commit into
SisyphusZheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the lockfile contains unpinned remote specifiers (e.g.
efs/heads/main), upstream pushes can cause deno install to fail with an integrity check error. The current AGENTS.md instructs contributors to manually edit the hash in deno.lock, which is error-prone and unnecessary.
Root cause
denoland/deno#32991 was closed as working as intended — Deno's integrity check is correct. deno cache --reload re-fetches content but still validates against the old integrity, so it fails. The proper approach is --lock-write, which tells Deno to accept new content and update the lockfile.
Solution
Replace the manual hash editing instruction in AGENTS.md with the deno install --lock-write command, which is Deno's official recommended fix.