Skip to content

fix(billing): Avoid double OTP during add card via stripe#6371

Draft
Bowrna wants to merge 2 commits into
frappe:developfrom
Bowrna:avoid_double_otp
Draft

fix(billing): Avoid double OTP during add card via stripe#6371
Bowrna wants to merge 2 commits into
frappe:developfrom
Bowrna:avoid_double_otp

Conversation

@Bowrna

@Bowrna Bowrna commented May 7, 2026

Copy link
Copy Markdown
Contributor

Removed setup intent and going only with payment intent and storing the card information as part of it. Verfied in local and this persists the card info for future usage

@Bowrna Bowrna requested review from siduck and ssiyad as code owners May 7, 2026 14:13

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.23288% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (7d37130) to head (afe621c).
⚠️ Report is 217 commits behind head on develop.

Files with missing lines Patch % Lines
press/api/billing.py 12.50% 21 Missing ⚠️

❌ Your patch check has failed because the patch coverage (71.23%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6371      +/-   ##
===========================================
- Coverage    49.85%   49.83%   -0.02%     
===========================================
  Files          944      945       +1     
  Lines        78378    78394      +16     
  Branches       350      355       +5     
===========================================
- Hits         39073    39068       -5     
- Misses       39281    39303      +22     
+ Partials        24       23       -1     
Flag Coverage Δ
dashboard 59.78% <100.00%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bowrna Bowrna marked this pull request as draft May 8, 2026 03:12
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.23288% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.83%. Comparing base (7d37130) to head (afe621c).
⚠️ Report is 869 commits behind head on develop.

Files with missing lines Patch % Lines
press/api/billing.py 12.50% 21 Missing ⚠️

❌ Your patch status has failed because the patch coverage (71.23%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6371      +/-   ##
===========================================
- Coverage    49.85%   49.83%   -0.02%     
===========================================
  Files          944      945       +1     
  Lines        78378    78394      +16     
  Branches       350      355       +5     
===========================================
- Hits         39073    39068       -5     
- Misses       39281    39303      +22     
+ Partials        24       23       -1     
Flag Coverage Δ
dashboard 59.78% <100.00%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants